Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(splash): Support SplashScreenBackgroundColor preference #1700

Merged
merged 1 commit into from
May 9, 2024

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Mar 31, 2024

Platforms affected

Android

Motivation and Context

Adds support for the more general SplashScreenBackgroundColor preference.

Description

Sets the splashscreen background based on the following options (in order):

  • AndroidWindowSplashScreenBackground preference
  • SplashScreenBackgroundColor preference
  • BackgroundColor preference
  • #ffffff hardcoded

Testing

Didn't seem like there were any existing unit tests for the splashscreen stuff, so I didn't update any tests.

  • This still needs to be tested manually in an Android project.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • I've updated the documentation if necessary

Sorry, something went wrong.

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 72.15%. Comparing base (b773ae4) to head (99532c2).

Files Patch % Lines
lib/prepare.js 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1700      +/-   ##
==========================================
- Coverage   72.35%   72.15%   -0.20%     
==========================================
  Files          23       23              
  Lines        1834     1839       +5     
==========================================
  Hits         1327     1327              
- Misses        507      512       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Verified

This commit was signed with the committer’s verified signature.
dpogue Darryl Pogue
@dpogue dpogue force-pushed the splash-background branch from 1782ad8 to 99532c2 Compare May 9, 2024 06:24
@dpogue dpogue marked this pull request as ready for review May 9, 2024 06:54
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

Also tested using the three preferences with Cordova's default template app. Confirmed order of priority.

@erisu erisu merged commit 7fa4a65 into apache:master May 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants