-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CB-14101 Fix Java version check for Java >= 9 #446
Conversation
I actually wanted to use semver for this, but with the dependency bundling it was too much of a hassle. |
Added node 4 compatibility so we can release this in a patch release |
Codecov Report
@@ Coverage Diff @@
## master #446 +/- ##
==========================================
+ Coverage 44.16% 44.21% +0.04%
==========================================
Files 17 17
Lines 1698 1694 -4
Branches 314 312 -2
==========================================
- Hits 750 749 -1
+ Misses 948 945 -3
Continue to review full report at Codecov.
|
This also checks that we have exactly 1.8 since nothing else works with the Android SDK. The user facing error was updated accordingly.
Actually, there's a bug 🤕 |
Now it should be fine. Test coverage is a great thing 😅 |
This also checks that we have exactly 1.8 since nothing else works with the Android SDK. The user facing error was updated accordingly.
This also checks that we have exactly 1.8 since nothing else works with the Android SDK. The user facing error was updated accordingly.
This also checks that we have exactly 1.8 since nothing else works with the Android SDK. The user facing error was updated accordingly.
This also checks that we have exactly 1.8 since nothing else works with the Android SDK. The user facing error was updated accordingly.
Platforms affected
Android
What does this PR do?
What testing has been done on this change?
The relevant function was not covered by unit tests to begin with, so I only tested this manually with the following code:
Output for Java 8 is
1.8.0
, for Java 10 is10.0.1
.Checklist
Added automated test coverage as appropriate for this change