-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add Node.js 12 to CI WIP with known test failure #770
Conversation
Co-authored-by: Jan Piotrowski <piotrowski+git@gmail.com> Co-authored-by: Christopher J. Brody <chris@brody.consulting>
82e78a8
to
a93af20
Compare
I find it really strange that Travis CI succeeds (with the ignored test failure) on Node.js on my fork but while it errors on the main Apache cordova-android project. Any ideas? |
That is indeed strange, although I don't really understand why this needs another PR besides #766. |
…to ci-node-12-wip
I just merged the recent test updates, which now give us build failures on Node.js 12 as expected (see #767). But Node.js 12 on Travis CI seems to error on the Apache build (https://travis-ci.org/apache/cordova-android/jobs/558578993) while it fails with an actual test failure on my fork (https://travis-ci.org/brodybits/cordova-android/jobs/558578976). I wonder if we should send this to INFRA? |
Under "Build system information" you see: Apache build:
Your build:
and then loads of more differences. No idea if we can influence that, but I bet that is the reason. Asking INFRA would be a good idea. Maybe also asking Travis could help. |
(misclick) |
Explicit |
AppVeyor seems to be a different error:
|
Yes, that error came up at the end. Looks like something flakey :-( |
This includes a change that @janpio pushed to the
janpio-travis_node_12
branch (draft PR #766).I discovered that there is a hidden failure on Node.js 12, as reported by @breautek in #768. While output shows a singleF
character, the build seems ignore this failure on both Travis CI and AppVeyor CI.I think that further discussion of the ignored test failure should continue in #768.P.S. For some reason Travis CI still does not work on Node.js 12, which is very strange since this does work on my fork. But we can still see the ignored test failure on Node.js 12 on AppVeyor CI.Now with known test failure on Node.js 12, as reported in #767. The trick is to add
dist: trusty
setting near the beginning of.travis.yml
.