Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Added Node 14.x #975

Merged
merged 1 commit into from
Jul 24, 2020
Merged

ci: Added Node 14.x #975

merged 1 commit into from
Jul 24, 2020

Conversation

breautek
Copy link
Contributor

Adds Node 14.x to the CI matrix, which is the new current and will be the LTS later this year.

@timbru31 timbru31 requested a review from erisu May 15, 2020 08:58
@timbru31
Copy link
Member

This is the first addition of a non LTS to the testing matrix (if I'm correct).

Do we want to test those versions, too? Only the new, soon to be, LTS ones? I think we should discuss that :)

@erisu
Copy link
Member

erisu commented May 15, 2020

I think it is OK to include 14.x since it is a stable release version. But only as part of the test environment to begin with. No public announcement needed.

Officially, I believe we only recommend LTS. We might sometimes mention stable release is acceptable but with caution as there could be an issue due to the lack of testing on our end.

The benefit of adding it now is to try and catch the issues quickly and fix them before node reaches LTS. Which is always recommended to do. (Note: never the odd releases of node)

I would prefer we plan on adding node 14 after the major releases is pushed out and only to the CIs.

Currently I been only focused on getting node 12 out because it was already planned and announced.

We also already released a few repos with just node 12.

@breautek
Copy link
Contributor Author

I'd support waiting until all the planned out releases are actually released. Then if issues arise afterwards, we can patch fixes in.

I'd even support waiting until NodeJS 14 actually becomes in LTS state. While in "current" I think new features and rapid changes are still be applied, creating an uncertain environment. Node 14 LTS starts October 20, 2020.

@breautek breautek added this to the 10.0.0 milestone Jun 26, 2020
@erisu
Copy link
Member

erisu commented Jul 3, 2020

Pinning Track Issue: apache/cordova#223

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@erisu erisu modified the milestones: 10.0.0, 9.0.1 Jul 3, 2020
@breautek breautek merged commit a45217e into apache:master Jul 24, 2020
@breautek breautek deleted the node14 branch July 24, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants