Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(npm): adds package-lock.json files #63

Closed
wants to merge 1 commit into from

Conversation

timbru31
Copy link
Member

@timbru31 timbru31 commented Apr 1, 2020

Ref apache/cordova#4

Platforms affected

Motivation and Context

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu
Copy link
Member

erisu commented Apr 1, 2020

@jcesarmobile @raphinesse What do you think about adding the package-lock.json to the template_src which is the base cordova project? cordova create projectName

@raphinesse
Copy link
Contributor

I would neither add the top-level lockfile nor the one in template_src. The top-level file is useless as this package doesn't have any dependencies.

Regarding the template file: we potentially change the package name and version present in the template during cordova create. Those values will then differ between package.json and package-lock.json. npm would fix this on the next install, but at that point the file might already be committed into version control. Moreover I don't see a real benefit here.

So I think adding this would be more trouble than it's worth 👎

@timbru31
Copy link
Member Author

timbru31 commented Apr 1, 2020

Convinced! :)

@timbru31 timbru31 closed this Apr 1, 2020
@timbru31 timbru31 deleted the feat/package-lock branch April 1, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants