remove potential error when setting exit code

[Molkars]

this PR implements a more reliable way of setting the CLI's exit code in error cases.

Previously, I encountered this error when running the cli:

$ cordova build
TypeError [ERR_INVALID_ARG_TYPE]: The "code" argument must be of type number. Received type string ('ERR_UNHANDLED_ERROR')
    at process.set [as exitCode] (node:internal/bootstrap/node:123:9)
    at /opt/nodejs/lib/node_modules/cordova/bin/cordova:33:22

With this version, I get to see the root problem:

$ cordova build
Unhandled error. ('Parsing /home/me/hello/config.xml failed')

Platforms affected

Motivation and Context

Description

Testing

Checklist

• I've run the tests to see all new and existing tests pass
• I added automated test coverage as appropriate for this change
• Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
• If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
• I've updated the documentation if necessary

[Molkars]

sorry to ignore the PR format, but... very simple change.

[Molkars]

Fixed

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.68%. Comparing base (c06b573) to head (fbf16da).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #640   +/-   ##
=======================================
  Coverage   70.68%   70.68%           
=======================================
  Files           4        4           
  Lines         307      307           
=======================================
  Hits          217      217           
  Misses         90       90           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[breautek]

All test passes. If there are no objections in the next couple of days or so I'll do a merge so that this change is included on our next release.

[Riquelme1075]

Good evening, did you manage to resolve it? I’ve tried everything and still couldn’t fix it. This error appeared out of nowhere. For example, at 8 PM I ran cordova platform add android, and at 10 PM I removed the platform and ran cordova platform add android again, and this is what appeared:

typescript
Copiar código
C:\app teste\rclmarcador\rclmarcador>cordova platform add android
TypeError [ERR_INVALID_ARG_TYPE]: The "code" argument must be of type number. Received type string ('ERR_UNHANDLED_ERROR')
at process.set [as exitCode] (node:internal/bootstrap/node:123:9)
at C:\Users\maria\AppData\Roaming\npm\node_modules\cordova\bin\cordova:32:22

[Molkars]

Yeah, but change my not made its way into distributed releases yet

…

-------- Original message -------- From: Riquelme1075 ***@***.***> Date: 7/30/24 9:27 PM (GMT-05:00) To: apache/cordova-cli ***@***.***> Cc: Dillon Shaffer ***@***.***>, Author ***@***.***> Subject: Re: [apache/cordova-cli] remove potential error when setting exit code (PR #640) Good evening, did you manage to resolve it? I’ve tried everything and still couldn’t fix it. This error appeared out of nowhere. For example, at 8 PM I ran cordova platform add android, and at 10 PM I removed the platform and ran cordova platform add android again, and this is what appeared: typescript Copiar código C:\app teste\rclmarcador\rclmarcador>cordova platform add android TypeError [ERR_INVALID_ARG_TYPE]: The "code" argument must be of type number. Received type string ('ERR_UNHANDLED_ERROR') at process.set [as exitCode] (node:internal/bootstrap/node:123:9) at C:\Users\maria\AppData\Roaming\npm\node_modules\cordova\bin\cordova:32:22 — Reply to this email directly, view it on GitHub<#640 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALDBE5CD2OPS7BCSYQ7FX5TZPA4QLAVCNFSM6AAAAABH677KLGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJZGQ2TSNJQGU>. You are receiving this because you authored the thread.Message ID: ***@***.***>