chore: Minor test fixes #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do this in the worst way possible because stuff depends on it being an instance of fs.Stats with the right prototype, but also there's no supported way to mock create an object of that type... so __proto__ hackery will have to suffice 😬
This should ensure that the directory is always cleaned up after tests run.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #211 +/- ##
=======================================
Coverage 88.40% 88.40%
=======================================
Files 20 20
Lines 1147 1147
=======================================
Hits 1014 1014
Misses 133 133 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
None
Motivation and Context
Resolves some deprecations warnings printed to the console in Node 22.
Description
fs.Statsconstructor is deprecated in Node 22 and prints a warning to the console, so we want to find a way to avoid hitting thattmpnpm module to handle this betterTesting
Ran unit tests locally on Node 22.
Checklist