Promise handling cleanup in specs #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @raphinesse, the cleanup looks nice. And none of the updated test cases seem to fail on jasmine@latest. I do have a couple more questions for you that I will ask on PR #74. |
|
@brodybits I also have a follow-up PR that would handle the update to jasmine@3.4 that builds upon this PR. Just waiting for approval to merge. |
brody4hire
approved these changes
Jun 18, 2019
4 tasks
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some general Promise handling cleanup in the specs. Nothing exciting. The same patterns I applied in cordova-lib.
Triggered by #74.