Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About SwiftSupport #880

Merged
merged 1 commit into from
Sep 12, 2018
Merged

Conversation

knight9999
Copy link
Contributor

Platforms affected

Documents (about iOS)

What does this PR do?

This PR is document part of following PRs
apache/cordova-ios#395
apache/cordova-common#42

  1. doc for adding new feature to specify swift version in config.xml.
  2. doc for adding new feature to specify the bridging-header file in plugin.xml

What testing has been done on this change?

By building docs on local environment.

Checklist

  • Commit message follows the format: "GH-3232: (android) Fix bug with resolving file paths", where GH-xxxx is the GitHub issue ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@@ -283,12 +283,14 @@ Attributes(type) <br/> <span class="sub-header">Only for platform:</span> | Desc
---------------- | ------------
src(string) | *Required* <br/> Location of the file relative to `plugin.xml`. If the src file can't be found, the CLI stops and reverses the installation, issues a notification about the problem, and exits with a non-zero code.
target-dir(string) | A directory into which the files should be copied, relative to the root of the Cordova project.
type(string) | If this value is `BridgingHeader`, the file is imported in the `Bridging-Header.h` and can be called from swift program. (only working in ios platform).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"(only working in ios platform)" should be replaced with <br/> ==iOS== in the first column which will render a nice Apple logo.

@knight9999
Copy link
Contributor Author

@janpio Thanks for the advice. I have updated my PR to use <br/> ==iOS==

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants