Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: npmrc #18

Merged
merged 1 commit into from
Sep 17, 2021
Merged

chore: npmrc #18

merged 1 commit into from
Sep 17, 2021

Conversation

breautek
Copy link
Contributor

Progresses apache/cordova#299

@breautek breautek mentioned this pull request Sep 13, 2021
Open
36 tasks
@breautek breautek changed the title Npmrc chore: npmrc Sep 13, 2021
erisu
erisu requested changes Sep 17, 2021
View reviewed changes
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes including the pacakge-lock.json change is incorrect.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@erisu
Copy link
Member

erisu commented Sep 17, 2021

Oh, it seems that this PR was based off another branch which also has its own PR.
I wonder if this PR should be based off master instead since the other PR is a major change and will require a major release. While this could go into a patch.

@breautek
Copy link
Contributor Author

Yah I'll rebase. I didn't realise I branched off of another branch instead of master.

@breautek breautek merged commit f83e646 into master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erisu erisu erisu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@breautek @erisu