Skip to content

Commit

Permalink
chore(ci): Fix dependabot code scanning errors (#121)
Browse files Browse the repository at this point in the history
* chore(ci): Fix dependabot code scanning errors

Dependabot pushes a branch to the repo and opens a pull request. The
pull request workflow runs properly, but the push workflow fails because
dependabot doesn't have access to a read/write GITHUB_TOKEN and doesn't
have access to the repo secrets.

The quick fix is telling CI not to run the push event workflow for
branches that start with `dependabot/`.

* chore(ci): Add Node 22 to CI
  • Loading branch information
dpogue authored Oct 23, 2024
1 parent 1a9703e commit 3b15497
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,21 @@

name: Node CI

on: [push, pull_request]
on:
push:
branches-ignore:
- 'dependabot/*'
pull_request:
branches:
- '*'

jobs:
test:
name: NodeJS ${{ matrix.node-version }} on ${{ matrix.os }}
runs-on: ${{ matrix.os }}
strategy:
matrix:
node-version: [16.x, 18.x, 20.x]
node-version: [16.x, 18.x, 20.x, 22.x]
os: [ubuntu-latest, windows-latest, macos-latest]

steps:
Expand Down

0 comments on commit 3b15497

Please sign in to comment.