[CB-14140] Remove shelljs #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpogue
reviewed
Jun 14, 2018
package.json
Outdated
| "q": "^1.4.1", | ||
| "shelljs": "^0.7.0" | ||
| "shelljs": "^0.7.0", |
There was a problem hiding this comment.
Are we able to remove shelljs entirely from the package.json?
There was a problem hiding this comment.
Of course. Good catch. Will update this to remove it.
Embarrassing oversight given the title of the PR 😅
raphinesse
force-pushed
the
remove-shelljs
branch
from
629b794 to
f3ff686
Compare
|
Linking this wonderful change in progress to Apache CB-14140 (https://issues.apache.org/jira/browse/CB-14140). |
|
@dpogue Are you fine with me merging this? |
brodycj
pushed a commit
to brodycj/cordova-fetch
that referenced
this pull request
Aug 6, 2018
brodycj
pushed a commit
to brodycj/cordova-fetch
that referenced
this pull request
Aug 6, 2018
Needed to support fs-extra in spec only in patch release FUTURE TBD may be removed from devDependencies if [apacheGH-23] shelljs -> fs-extra is completely ported to 1.3.x. NOT WANTED in master
brodycj
pushed a commit
to brodycj/cordova-fetch
that referenced
this pull request
Aug 6, 2018
partial cherry-pick from master, shelljs still in index.js & fetch-unit.spec.js FUTURE TBD: cherry-pick remaining changes & remove fs-extra from devDependencies
brodycj
pushed a commit
to brodycj/cordova-fetch
that referenced
this pull request
Aug 6, 2018
to avoid caching
This was referenced Aug 6, 2018
brodycj
pushed a commit
to brodycj/cordova-fetch
that referenced
this pull request
Aug 14, 2018
brodycj
pushed a commit
to brodycj/cordova-fetch
that referenced
this pull request
Aug 14, 2018
Needed to support fs-extra in spec only in patch release FUTURE TBD may be removed from devDependencies if [apacheGH-23] shelljs -> fs-extra is completely ported to 1.3.x. NOT WANTED in master
brodycj
pushed a commit
to brodycj/cordova-fetch
that referenced
this pull request
Aug 14, 2018
partial cherry-pick from master, shelljs still in index.js & fetch-unit.spec.js FUTURE TBD: cherry-pick remaining changes & remove fs-extra from devDependencies
brodycj
pushed a commit
to brodycj/cordova-fetch
that referenced
this pull request
Aug 14, 2018
to avoid caching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.