Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates have not been upgraded for XCode 10 #844

Closed
landabaso opened this issue May 15, 2020 · 1 comment
Closed

Templates have not been upgraded for XCode 10 #844

landabaso opened this issue May 15, 2020 · 1 comment

Comments

@landabaso
Copy link

landabaso commented May 15, 2020

For example, this file:

https://github.com/apache/cordova-ios/blob/master/bin/templates/project/__TEMP__.xcodeproj/project.pbxproj

still uses developmentRegion = English; (which is deprecated) instead of developmentRegion = en;

Compare it to:
https://github.com/dpogue/cordova-ios/blob/master/CordovaLib/CordovaLib.xcodeproj/project.pbxproj

They do not match. master fixes some of these inconsistencies (not all of them such as developmentRegion). What is worse, last release 5.1.1 targets compatibilityVersion = "Xcode 3.2";, which is pretty old.
See: https://github.com/apache/cordova-ios/blob/rel/5.1.1/bin/templates/project/__TEMP__.xcodeproj/project.pbxproj

There were many fixes applied in pull request #489 for CordovaLib.

But templates did not get those changes or got them partially wrong.

I'm not an expert in Cordova but I believe these templates are used to create the XCode project.

I found XCode was warning about a bunch of issues in my project which had been already solved for CordovaLib. I believe that the templates should have been upgraded accordingly.

@erisu
Copy link
Member

erisu commented Jun 11, 2020

Templates were updated and released.

@erisu erisu closed this as completed Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants