-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CordovaLib.xcodeproj file upgraded for Xcode 10 #489
Conversation
Codecov Report
@@ Coverage Diff @@
## master #489 +/- ##
=======================================
Coverage 74.75% 74.75%
=======================================
Files 11 11
Lines 1822 1822
=======================================
Hits 1362 1362
Misses 460 460 Continue to review full report at Codecov.
|
Looks like the TravisCI tests all pass with Xcode 9. However, we don't seem to have Xcode 10 TravisCI tests in the matrix |
@shazron I've reduced this back to just the CordovaLib.xcodeproj and CordovaLib deprecation changes, and added Xcode 10.1 to the CI matrix on Travis (while keeping a single run of Xcode 9.3 as a backward-compatibility check, pending further discussion) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Platforms affected
iOS
What does this PR do?
Upgrades CordovaLib.xcodeproj to Xcode 10 standards
What testing has been done on this change?
All the objc unit tests pass locally with Xcode 10.1, opening this PR to see how they are handled by Xcode 9.