-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDVWebViewEngine needs a way to set the websiteDataStore of its configuration #900
Milestone
Comments
8 tasks
msmtamburro
added a commit
to msmtamburro/cordova-ios
that referenced
this issue
Jan 5, 2021
…View configuration (apache#900)
5 tasks
msmtamburro
added a commit
to msmtamburro/cordova-ios
that referenced
this issue
Jan 5, 2021
* issue_900_websiteDataStore: fix: update the existing tests of the default behavior feat: add CDVWebViewEngineConfigurationDelegate to fully expose WKWebView configuration (apache#900) # Conflicts: # CordovaLib/Classes/Private/Plugins/CDVWebViewEngine/CDVWebViewEngine.m
dpogue
pushed a commit
that referenced
this issue
Oct 1, 2021
* feat: add CDVWebViewEngineConfigurationDelegate to fully expose WKWebView configuration (#900) * fix: update the existing tests of the default behavior * chore: bring back initWithFrame, as existing CDVWebViewEngineProtocol conforming plugins use it * chore: clean up newCordovaViewWithFrame in order to extract initialization with configuration * chore: find existing methods that can return nil, and mark them as such for clarity
5 tasks
gazben
pushed a commit
to apicore-engineering/cordova-ios
that referenced
this issue
Aug 26, 2022
* feat: add CDVWebViewEngineConfigurationDelegate to fully expose WKWebView configuration (apache#900) * fix: update the existing tests of the default behavior * chore: bring back initWithFrame, as existing CDVWebViewEngineProtocol conforming plugins use it * chore: clean up newCordovaViewWithFrame in order to extract initialization with configuration * chore: find existing methods that can return nil, and mark them as such for clarity
Apologies: the code for this fix ended up in the (merged) PR to address 1157. I verified that everything looks good locally in cordova-ios@7.0.1. (I can successfully utilize the CDVWebViewEngineConfigurationDelegate to update the configuration of the CDVWebViewEngine.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature Request
Motivation Behind Feature
A websiteDataStore can both be configured (e.g., set to non-persistent) and re-used (e.g., in other web browser components).
Feature Description
Optionally exposing the configuration as typically done with the "Cordova settings" model may not suffice. For example, if you only added a Cordova setting for persistent vs. non-persistent, this would still not give us a handle to the websiteDataStore for re-use elsewhere. More specifically, allowing Cordova to use an existing websiteDataStore that was created and used prior to Cordova reaching its
createConfigurationFromSettings
method is important in my case. You could accomplish this by providing a protocol that allows us to return a websiteDataStore.For example, add the following lines to CDVWebViewEngine.h:
and then expose this property:
And finally, in CDVWebViewEngine.m, inside of
createConfigurationFromSettings:
start with:Alternatives or Workarounds
When using the CDVWKWebViewEngine (the old plugin), it was possible to override createConfigurationFromSettings to customize portions of the configuration that were not exposed through Cordova settings. With the migration to CDVWebViewEngine, its private status prevents this type of customization without resorting to swizzling.
The text was updated successfully, but these errors were encountered: