Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SplashScreenDelay should not apply when calling splashscreen.show() / splashscreen.hide() #991

Closed
3 tasks done
asgeo1 opened this issue Sep 23, 2020 · 3 comments · Fixed by #1006
Closed
3 tasks done
Milestone

Comments

@asgeo1
Copy link

asgeo1 commented Sep 23, 2020

Bug Report

Problem

Calling splashscreen.show() or splashscreen.hide() do not function correctly when SplashScreenDelay is set to a value.

What is expected to happen?

Manually calling splashscreen.show() or splashscreen.hide() should trigger the splash screen to show/hide immediately. The value of SplashScreenDelay is only meant to be taken into account when the app first loads and AutoHideSplashScreen is true - i.e. it's for controlling the initial delay when the app first boots.

(at least, this is how the documentation reads, and how it used to work on previous versions of the splash screen plugin)

One should be able to manually show/hide the splash screen immediately as required.

What does actually happen?

Calling splashscreen.show() or splashscreen.hide(), there is a delay before the action actually happens - the delay being the value of SplashScreenDelay.

Information

Command or Code

Environment, Platform, Device

iOS any version

Version information

Cordova iOS 6.1.1

Checklist

  • I searched for existing GitHub issues
  • I updated all Cordova tooling to most recent version
  • I included all the necessary information above
BendingBender added a commit to treefin/cordova-ios that referenced this issue Oct 10, 2020
Make hiding of splash screen a race between `SplashScreenDelay` setting
and navigator.splashscreen.hide().

Related issue: apache#991
BendingBender added a commit to treefin/cordova-ios that referenced this issue Oct 10, 2020
Make hiding of splash screen a race between `SplashScreenDelay` setting
and navigator.splashscreen.hide().

Related issue: apache#991
BendingBender added a commit to treefin/cordova-ios that referenced this issue Oct 10, 2020
Make hiding of splash screen a race between `SplashScreenDelay` setting
and navigator.splashscreen.hide().

Related issue: apache#991
BendingBender added a commit to treefin/cordova-ios that referenced this issue Oct 10, 2020
Make hiding of splash screen a race between `SplashScreenDelay` setting
and navigator.splashscreen.hide().

Related issue: apache#991
dpogue pushed a commit that referenced this issue Oct 10, 2020
Make hiding of splash screen a race between `SplashScreenDelay` setting
and navigator.splashscreen.hide().

Related issue: #991
@dpogue dpogue added this to the 6.1.2 milestone Oct 10, 2020
@svzi
Copy link

svzi commented Oct 20, 2020

@dpogue When can we expect the version 6.1.2 to be released?

@timbru31
Copy link
Member

As Cordova is maintained by volunteers, often in their free time, we can't give any ETA on release dates.

@svzi
Copy link

svzi commented Oct 20, 2020

I fully understand and appreciate the support of all the volunteers! Keep up the good work. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants