Don't show splashscreen when using standalone CDVViewController #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using CDVViewController via CordovaLib as a library, the app might already be loaded and not need to show the launch storyboard again. Rather than unconditionally showing the splashscreen until the webview content has loaded, make it initially invisible. Then in the project template, make it visible so that it continues working as expected for apps using the Cordova CLI. Closes apache#929.
dpogue
changed the title
NiklasMerz
reviewed
Dec 2, 2020
There was a problem hiding this comment.
I am still an ObjectiveC noob but trying to learn stuff. Why not use the hidden property here?
https://developer.apple.com/documentation/uikit/uiview/1622585-hidden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
Closes #929
Description
When using CDVViewController via CordovaLib as a library, the app might already be loaded and not need to show the launch storyboard again.
Rather than unconditionally showing the splashscreen until the webview content has loaded, make it initially invisible. Then in the project template, make it visible so that it continues working as expected for apps using the Cordova CLI.
Testing
Manual testing
Checklist