-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set CDVWebViewProcessPoolFactory to public #1031
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1031 +/- ##
===========================================
+ Coverage 0 74.91% +74.91%
===========================================
Files 0 13 +13
Lines 0 1718 +1718
===========================================
+ Hits 0 1287 +1287
- Misses 0 431 +431
Continue to review full report at Codecov.
|
The problem is that this is not part of our public API, it's part of a built-in internal plugin. It lives in CDVWebViewProcessPoolFactory is fairly small and self-contained though, so maybe it makes sense to move that one class into the public API? |
By setting the checkbox it becomes public and works. But I would agree that moving it to |
I did another commit and moved the class to the Does anyone know reasons why this is private with the other plugins? Any known issues in the past? |
… note: works around, rather than addresses existing architectural issues (apache#1031)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the reviews. If nobody objects I will merge this in 24 hours together with apache/cordova-plugin-inappbrowser#825. |
Platforms affected
iOS
Motivation and Context
The InAppBrowser used to import the process pool from the wkwebview plugin. Now the processpool is in the iOS platform and got renamed. Because it's in the private part InAppBrowser can never import it and use the shared pool.
See this issue: apache/cordova-plugin-inappbrowser#751 and PR apache/cordova-plugin-inappbrowser#825
Description
I just set the file to public in Xcode.
From my understanding this should be public for plugins to use (like IAB to share Cookies). I am not sure if this is the right way to make this public though. Are there any other problems for having this private?
Testing
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)