-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore): update dependencies for minor release #1069
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1069 +/- ##
=======================================
Coverage 74.88% 74.88%
=======================================
Files 13 13
Lines 1724 1724
=======================================
Hits 1291 1291
Misses 433 433 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notable changes:
find-process@1.4.4
- ✔️ Security patch for Windows users
tmp@0.2.1
- ✔️ Resolves an issue where
tmp
willprocess.exit
itself.
fs-extra@9.1.0
- ✔️ Performance improvements
nopt@5.0.0
Haven't maintained a changelog since version 4.0.1. Upgrading a major without knowing what has changed is a bit sketchy, but their package.json
says they support >= node 6. I suppose as long as our tests passes then we are still ok.
semver@7.3.4
Haven't maintained a changelog since version 7.3.0. Patch increments should be okay.
Thanks @breautek for the summary. Regarding |
In the comment you say wanted 4.0.3 but updated to 5.0.0. Not saying we shouldn’t update to 5.0.0, only that the description is confusing. |
NPM outdated wanted 4.0.3. Since I did not find dangerous changes in 5.0.0 (see previous comment) I updated to the latest version. 5.0.0 looks save but I can revert that. |
Just saying that the PR change doesn’t do what you say it does in the or description, you can just update the description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you all for the feedback |
Platforms affected
iOS
Motivation and Context
Working through the release process I found some outdated dependencies:
Description
I updated dependencies and found no issues locking at the release notes and test results. They should fit in this minor release.
Some packages turned tests red and are major upgrades. I created an issue for the next version: #1068
Testing
Tests and CI
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)