Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore): update dependencies for minor release #1069

Merged
merged 2 commits into from
Feb 1, 2021

Conversation

NiklasMerz
Copy link
Member

@NiklasMerz NiklasMerz commented Jan 31, 2021

Platforms affected

iOS

Motivation and Context

Working through the release process I found some outdated dependencies:

Package       Current  Wanted  Latest  Location
find-process    1.4.3   1.4.4   1.4.4  cordova-ios
fs-extra        9.0.1   9.1.0   9.1.0  cordova-ios
ios-sim         8.0.2   8.0.2   9.0.0  cordova-ios
jasmine         3.5.0   3.5.0   3.6.4  cordova-ios
nopt            4.0.3   4.0.3   5.0.0  cordova-ios
semver          7.3.2   7.3.4   7.3.4  cordova-ios
tmp             0.1.0   0.1.0   0.2.1  cordova-ios

Description

I updated dependencies and found no issues locking at the release notes and test results. They should fit in this minor release.

Some packages turned tests red and are major upgrades. I created an issue for the next version: #1068

Testing

Tests and CI

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-io
Copy link

codecov-io commented Jan 31, 2021

Codecov Report

Merging #1069 (1df6063) into master (e1cc096) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1069   +/-   ##
=======================================
  Coverage   74.88%   74.88%           
=======================================
  Files          13       13           
  Lines        1724     1724           
=======================================
  Hits         1291     1291           
  Misses        433      433           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1cc096...1df6063. Read the comment docs.

@NiklasMerz NiklasMerz added this to the 6.2.0 milestone Jan 31, 2021
Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notable changes:

find-process@1.4.4

  • ✔️ Security patch for Windows users

tmp@0.2.1

  • ✔️ Resolves an issue where tmp will process.exit itself.

fs-extra@9.1.0

  • ✔️ Performance improvements

nopt@5.0.0

Haven't maintained a changelog since version 4.0.1. Upgrading a major without knowing what has changed is a bit sketchy, but their package.json says they support >= node 6. I suppose as long as our tests passes then we are still ok.

semver@7.3.4

Haven't maintained a changelog since version 7.3.0. Patch increments should be okay.

@NiklasMerz
Copy link
Member Author

Thanks @breautek for the summary.

Regarding nopt: Seems like they just did a small dependency update: npm/nopt@v4.0.3...v5.0.0

@jcesarmobile
Copy link
Member

In the comment you say wanted 4.0.3 but updated to 5.0.0.
Also says “minor and patch” but that’s major.

Not saying we shouldn’t update to 5.0.0, only that the description is confusing.

@NiklasMerz
Copy link
Member Author

NPM outdated wanted 4.0.3. Since I did not find dangerous changes in 5.0.0 (see previous comment) I updated to the latest version.

5.0.0 looks save but I can revert that.

@jcesarmobile
Copy link
Member

Just saying that the PR change doesn’t do what you say it does in the or description, you can just update the description

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NiklasMerz NiklasMerz merged commit 4efd400 into master Feb 1, 2021
@NiklasMerz NiklasMerz deleted the update-dependencies branch February 1, 2021 15:41
@NiklasMerz
Copy link
Member Author

Thank you all for the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants