-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(ios) fix: workaround for DisallowOverscroll on iOS 16 #1258
(ios) fix: workaround for DisallowOverscroll on iOS 16 #1258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like for consistency, we do also want to set scrollView.alwaysBounceHorizontal = NO;
otherwise there's a risk of unwanted side-to-side rubberbanding.
dccf238
to
f192df1
Compare
Good point, added. |
Codecov Report
@@ Coverage Diff @@
## master #1258 +/- ##
=======================================
Coverage 78.26% 78.26%
=======================================
Files 15 15
Lines 1767 1767
=======================================
Hits 1383 1383
Misses 384 384 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@dpogue when do you intend to release 6.2.1? |
This issue looks to have been fixed in iPadOS 16.2 released yesterday (Dec 13th). |
Platforms affected
iOS 16
Motivation and Context
iOS 16 breaks DisallowOverscroll setting, this PR adds workaround discussed in #1244
Description
Disabling both
webView.scrollView.bounce
andwebView.scrollView.alwaysBounceVertical
Testing
Manually tested on iOS 15 and iOS 16
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)Closes #1244