Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(CordovaLib): Start filling out DocC comments #1476

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Aug 24, 2024

Platforms affected

iOS

Motivation and Context

The API available to people embedding CordovaLib as a framework in their existing apps is not well documented, nor is the API available to plugin authors.

With DocC comments, we can generate Apple-style documentation for our framework, and serve it on GitHub Pages.

Description

Add DocC comments to some of CordovaLib and add a main page file. This is only an initial pass over the sections of code that I've been touching recently, but the goal is to have everything that's public API commented appropriately.

Testing

Existing tests pass.
Built documentation bundle with Xcode for local testing.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I've updated the documentation if necessary

@dpogue dpogue added this to the 8.0.0 milestone Aug 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.22%. Comparing base (8e59e52) to head (55e5a33).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1476   +/-   ##
=======================================
  Coverage   80.22%   80.22%           
=======================================
  Files          16       16           
  Lines        1871     1871           
=======================================
  Hits         1501     1501           
  Misses        370      370           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ran basic tests (Cordova sample app & Cordova Plugins)

@dpogue dpogue force-pushed the docc-docs branch 3 times, most recently from 55e5a33 to c247924 Compare August 25, 2024 20:27
@dpogue dpogue merged commit 458f5f3 into apache:master Aug 26, 2024
10 checks passed
@dpogue dpogue deleted the docc-docs branch August 26, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants