fix(emulators): Fix listing emulator targets #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpogue
commented
Oct 8, 2024
| @@ -248,8 +248,8 @@ function execListDevices () { | |||
| } | |||
|
|
|||
| /* istanbul ignore next */ | |||
| function execListEmulatorTargets () { | |||
| return require('./listEmulatorTargets').run(); | |||
There was a problem hiding this comment.
This line is the key change here. Almost everything else is just renaming this function to match what it's actually doing.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1495 +/- ##
==========================================
- Coverage 80.89% 80.86% -0.03%
==========================================
Files 16 16
Lines 1842 1840 -2
==========================================
- Hits 1490 1488 -2
Misses 352 352 ☔ View full report in Codecov by Sentry. |
erisu
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
I think I accidentally broke this during earlier refactoring for 8.0.0, but it was now trying to (and incorrectly) listing the simulator devices rather than the simulator device/runtime combinations.
Description
Restore the correct listing for simulator devices/runtimes when using
cordova run ios --listTesting
Tested running
npx cordova run ios --listand ensured the output matched between these changes and 7.1.1Checklist