Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-12582: exec purgeProjectFileCache when pod install #354

Merged
merged 1 commit into from
Feb 26, 2018

Conversation

knight9999
Copy link
Contributor

@knight9999 knight9999 commented Jan 29, 2018

CB-12582

Platforms affected

Cordova iOS 4.5.4

What does this PR do?

Fix the pod install plugin (plugin with podspec framework) to work.

For example, phonegap-plugin-push plugin with GoogleService-Info.plist
(in config.xml, <resource-file src="GoogleService-Info.plist" /> is added)

The case,

cordova platform add ios@4.5.4
cordova plugin add phongegap-plugin-push
cordova prepare
cordova compile --device

works well.
The case,

cordova plugin add phonegap-plugin-push
cordova platform add ios@4.5.4
cordova prepare
cordova compile --device

does not work becuase the cordova overwrite project.pbxproj which is changed by pod install.
This pull request fixes this issue.

What testing has been done on this change?

Do in my local environment with cordova-ios 4.5.4

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@codecov-io
Copy link

Codecov Report

Merging #354 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #354      +/-   ##
==========================================
+ Coverage   63.45%   63.47%   +0.02%     
==========================================
  Files          14       14              
  Lines        1691     1692       +1     
  Branches      284      284              
==========================================
+ Hits         1073     1074       +1     
  Misses        618      618
Impacted Files Coverage Δ
bin/templates/scripts/cordova/Api.js 54.19% <100%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e51796...62b9b41. Read the comment docs.

@shazron
Copy link
Member

shazron commented Jan 29, 2018

Thank you for the PR! I think there is a related issue in JIRA, I'll try to find to it and link to it.

@knight9999
Copy link
Contributor Author

Yes, I think the link is same issue I met.
pod install command update project.pbxproj we should clear the cache as my PR.

@shazron
Copy link
Member

shazron commented Feb 8, 2018

Can you add a prefix to this PR title? Add "CB-12582 " to enable auto GH and JIRA issue linking

@knight9999 knight9999 changed the title exec purgeProjectFileCache when pod install CB-12582 exec purgeProjectFileCache when pod install Feb 9, 2018
@knight9999 knight9999 changed the title CB-12582 exec purgeProjectFileCache when pod install CB-12582: exec purgeProjectFileCache when pod install Feb 9, 2018
@shazron shazron merged commit 01742bf into apache:master Feb 26, 2018
shazron added a commit that referenced this pull request Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants