CB-13927 - Modified xcodeProjDir to filter out files/folders that contain "._"

[asoap]

I ran into an issue trying to add an ios plugin using a virtual machine. The code would return an array for the xcodeProjDir and then of course use the wrong one. It would use the one starting with "._ProjectName" which I believe is an MacOS hidden folder. I attempted to install the plugin on OsX but because it's a virtual machine it still had those hidden folders. I've made it so that it will filter those out while looking for the proper xCode project folder.

Platforms affected

Windows (host) / OSx (guest) virtual machines

What does this PR do?

Fixes a folder issue. Before it would try to use an incorrect folder for the xCode project.

What testing has been done on this change?

I made the change while trying to install a patch. It should work the same as before as this code is only executed if there is more than one folder returned from searching the file system.

Checklist

• Reported an issue in the JIRA database
• Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
• Added automated test coverage as appropriate for this change.

[asoap]

I'm new to this, and I see my code failed the test. Is this the only thing it failed on?

C:\projects\cordova-ios\bin\templates\scripts\cordova\Api.js
67:1 error Trailing spaces not allowed no-trailing-spaces
70:1 error Expected indentation of 12 spaces but found 10 indent
71:1 error Expected indentation of 16 spaces but found 12 indent
71:50 error A space is required after ',' comma-spacing
72:1 error Expected indentation of 20 spaces but found 14 indent
72:42 error A space is required after ',' comma-spacing
73:1 error Expected indentation of 16 spaces but found 12 indent
74:1 error Expected indentation of 12 spaces but found 10 indent
77:1 error Trailing spaces not allowed no-trailing-spaces

[surajpindoria]

Hi @asoap,

Looks like those are the only errors, so fixing these should be enough to get the CI passing

[codecov-io]

Codecov Report

Merging #355 into master will decrease coverage by 0.06%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
- Coverage   63.45%   63.38%   -0.07%     
==========================================
  Files          14       14              
  Lines        1691     1696       +5     
  Branches      284      286       +2     
==========================================
+ Hits         1073     1075       +2     
- Misses        618      621       +3

Impacted Files	Coverage Δ
bin/templates/scripts/cordova/Api.js	53.45% <50%> (-0.44%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e51796...c8f704c. Read the comment docs.

[asoap]

YAY!!!!!

Look at me, I'm helping. 👯‍♂️

[shazron]

@asoap I would like to get this in, however two things are needed:

1. File an issue in issues.cordova.io
2. Prefix the title of this PR with the JIRA issue tag (i.e. CB-XXXX)

[shazron]

Ping @asoap . If no progress on this for this week, this will be bumped until next release.

[shazron]

Thanks! I think this would be more efficient and clearer, what do you think?

var xcodeProjDir_array = fs
    .readdirSync(this.root)
    .filter(function (elem) {
        // match .xcodeproj, and not start with '._'
        return elem.match(/\.xcodeproj$/i) && (elem.substring(0, 2) !== '._'); 
    })

xcodeProjDir = xcodeProjDir_array[0];      

[shazron]

Added JIRA issue, modified the title, and commented on the code.