Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH#396: Update Objc-Test for Local & TravisCI #397

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

erisu
Copy link
Member

@erisu erisu commented Aug 23, 2018

Platforms affected

ios tests

What does this PR do?

See #396 for more details.

This will allow tests to pass successfully on Travis CI and locally when using Xcode 9.3 or higher.

What testing has been done on this change?

@codecov-io
Copy link

codecov-io commented Aug 23, 2018

Codecov Report

Merging #397 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #397   +/-   ##
=======================================
  Coverage   73.68%   73.68%           
=======================================
  Files          11       11           
  Lines        1463     1463           
=======================================
  Hits         1078     1078           
  Misses        385      385

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0d3dad...0164d4c. Read the comment docs.

Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This makes sense to me

@erisu erisu force-pushed the update-xcode-test-environment branch from 0164d4c to 545dc5e Compare August 27, 2018 07:47
@erisu erisu merged commit 9d2ea13 into apache:master Aug 29, 2018
erisu added a commit to erisu/cordova-ios that referenced this pull request Jan 16, 2019
@erisu erisu deleted the update-xcode-test-environment branch April 4, 2019 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants