Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue after updating to macOS 10.14.2. #474

Merged
merged 1 commit into from
Dec 13, 2018
Merged

Fix issue after updating to macOS 10.14.2. #474

merged 1 commit into from
Dec 13, 2018

Conversation

amorgulis
Copy link
Contributor

@amorgulis amorgulis commented Dec 13, 2018

After updating to macOS 10.14.2, running cordova run ios causes error Cannot read property 'name' of undefined. It turns out that the problem is due to device.name including the '-'. It seems this changed with the update to Xcode 10.1 which seems to have been bundled along with the 10.14.2 update.

Platforms affected

What does this PR do?

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

After updating to macOS 10.14.2, running `cordova run ios` causes error `Cannot read property 'name' of undefined`. It turns out that the problem is due to device.name including the '-'. It seems this changed with the update to Xcode 10.1 which seems to have been bundled along with the 10.14.2 update.
@codecov-io
Copy link

codecov-io commented Dec 13, 2018

Codecov Report

Merging #474 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #474   +/-   ##
=======================================
  Coverage   75.36%   75.36%           
=======================================
  Files          12       12           
  Lines        1802     1802           
=======================================
  Hits         1358     1358           
  Misses        444      444

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65015c1...7875211. Read the comment docs.

Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dpogue dpogue merged commit 8b6f35c into apache:master Dec 13, 2018
@amorgulis amorgulis deleted the patch-1 branch December 13, 2018 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants