Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit xcodebuild & other spawned CLI commands #479

Merged
merged 1 commit into from Dec 19, 2018
Merged

emit xcodebuild & other spawned CLI commands #479

merged 1 commit into from Dec 19, 2018

Conversation

oliversalzburg
Copy link
Contributor

Platforms affected

iOS

What does this PR do?

It logs the CLI for xcodebuild. Please note that this PR expects #477 to be merged also.

What testing has been done on this change?

None

@brodycj
Copy link
Contributor

brodycj commented Dec 18, 2018

Please note that this PR expects #477 to be merged also.

I think you meant PR #478. I would favor just adding the xcodebuild log fix to PR #478.

Copy link
Contributor

@brodycj brodycj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am requesting changes to avoid a premature merge:

@oliversalzburg
Copy link
Contributor Author

oliversalzburg commented Dec 18, 2018

@brodybits I wanted to keep this change in a separate PR so it will be listed as a discrete change in possible changelogs and to better track the individual change.

I would rebase this PR when #478 is merged, to get a cleaner merge.

Copy link
Contributor

@brodycj brodycj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-io
Copy link

codecov-io commented Dec 18, 2018

Codecov Report

Merging #479 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
- Coverage   75.71%   75.66%   -0.05%     
==========================================
  Files          11       11              
  Lines        1795     1796       +1     
==========================================
  Hits         1359     1359              
- Misses        436      437       +1
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/Podfile.js 73.02% <0%> (-0.35%) ⬇️
bin/templates/scripts/cordova/lib/build.js 57.71% <0%> (ø) ⬆️
bin/templates/scripts/cordova/lib/run.js 23.36% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4694547...ec9148d. Read the comment docs.

@oliversalzburg
Copy link
Contributor Author

This should be all good now :)

@oliversalzburg
Copy link
Contributor Author

@brodybits I pushed another update to put printCommand: true in all superspawn invokations. I missed that comment earlier.

Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@brodycj brodycj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @oliversalzburg

@brodycj brodycj changed the title Log xcodebuild CLI Log xcodebuild & other spawned CLI commands Dec 18, 2018
@brodycj
Copy link
Contributor

brodycj commented Dec 18, 2018

I just updated the title to better reflect the actual changes, will merge in a few minutes or so.

@brodycj brodycj changed the title Log xcodebuild & other spawned CLI commands emit xcodebuild & other spawned CLI commands Dec 19, 2018
@brodycj brodycj merged commit 2b55d33 into apache:master Dec 19, 2018
@brodycj
Copy link
Contributor

brodycj commented Dec 19, 2018

Merged with title updated again for the sake of clarity. Thanks again @oliversalzburg!

@oliversalzburg oliversalzburg deleted the feature/cli-log branch December 19, 2018 11:45
erisu pushed a commit to erisu/cordova-ios that referenced this pull request Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants