Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore stdio passthrough behavior #483

Merged
merged 1 commit into from Dec 19, 2018
Merged

Restore stdio passthrough behavior #483

merged 1 commit into from Dec 19, 2018

Conversation

oliversalzburg
Copy link
Contributor

@oliversalzburg oliversalzburg commented Dec 19, 2018

Platforms affected

iOS

What does this PR do?

It restores the stdio setting that was previously applied through the spawn.js shell execution utility.

In the current setting, previously visible console output would likely be hidden from the user.

What testing has been done on this change?

None

@codecov-io
Copy link

codecov-io commented Dec 19, 2018

Codecov Report

Merging #483 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #483   +/-   ##
=======================================
  Coverage   75.66%   75.66%           
=======================================
  Files          11       11           
  Lines        1796     1796           
=======================================
  Hits         1359     1359           
  Misses        437      437
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/build.js 57.71% <0%> (ø) ⬆️
bin/templates/scripts/cordova/lib/run.js 23.36% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b55d33...3458653. Read the comment docs.

@oliversalzburg oliversalzburg changed the title WIP: Restore stdio passthrough behavior Restore stdio passthrough behavior Dec 19, 2018
@brodycj brodycj requested review from dpogue and erisu December 19, 2018 11:51
Copy link
Contributor

@brodycj brodycj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on my part, would like another quick review since I am not so familiar with this behavior.

@brodycj brodycj merged commit 1d00e60 into apache:master Dec 19, 2018
@oliversalzburg oliversalzburg deleted the fix/stdio-inherit branch December 19, 2018 15:07
erisu pushed a commit to erisu/cordova-ios that referenced this pull request Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants