Replace ios-deploy with node-ios-device

[reck1610]

Closes #419, #420
Fixes #429

What does this PR do?

Replaces ios-deploy with node-ios-device.
Removes a global dependency.

Checklist

• Reported an issue in the JIRA database
• Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
• Added automated test coverage as appropriate for this change.

[janpio]

What was extraArgs used for?

[reck1610]

extraArgs contained the arguments not used by run.js.
It allowed to pass arguments to ios-deploy(ios-deploy usage).

[janpio]

Ok, so with your PR we loose this functionality. Which use case did it cover? What will not work any more for users that might be using this right now?

[shazron]

I think extraArgs is safe to ignore -- this would be any extra arguments to pass ios-deploy which we don't really officially support, but was "nice to have". If you do a cordova run --help you would see its the POPTS, which is not defined, thus we don't have any specific platform options.

We will have to remove any extraArgs code here as well:

cordova-ios/bin/templates/scripts/cordova/lib/run.js

Lines 101 to 106 in 1d00e60

	var extraArgs = [];
	if (runOptions.argv) {
	// argv.slice(2) removes node and run.js, filterSupportedArgs removes the run.js args
	extraArgs = module.exports.filterSupportedArgs(runOptions.argv.slice(2));
	}
	return module.exports.deployToDevice(appPath, runOptions.target, extraArgs);

[codecov-io]

Codecov Report

Merging #488 into master will decrease coverage by 0.38%.
The diff coverage is 12.5%.

@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
- Coverage   75.66%   75.27%   -0.39%     
==========================================
  Files          11       11              
  Lines        1796     1792       -4     
==========================================
- Hits         1359     1349      -10     
- Misses        437      443       +6

Impacted Files	Coverage Δ
bin/templates/scripts/cordova/lib/build.js	58.04% <ø> (+0.33%)	⬆️
bin/templates/scripts/cordova/lib/check_reqs.js	51.42% <ø> (-1.28%)	⬇️
bin/templates/scripts/cordova/lib/versions.js	91.02% <100%> (+0.32%)	⬆️
bin/templates/scripts/cordova/lib/run.js	21.55% <6.66%> (-1.82%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe01e5d...d8cd743. Read the comment docs.

[shazron]

Testing this right now.

[shazron]

Doesn't seem related, but I have an error with the below. Will debug:

[other build logs here]
** ARCHIVE SUCCEEDED **

Non-system Ruby in use. This may cause packaging to fail.
If you use RVM, please run `rvm use system`.
If you use chruby, please run `chruby system`.
Running command: xcodebuild -exportArchive -archivePath HelloCordova.xcarchive -exportOptionsPlist /Users/shaz/Desktop/foo/platforms/ios/exportOptions.plist -exportPath /Users/shaz/Desktop/foo/platforms/ios/build/device
2019-01-09 14:52:35.326 xcodebuild[97578:1313027] [MT] IDEDistribution: -[IDEDistributionLogging _createLoggingBundleAtPath:]: Created bundle at path '/var/folders/4h/x_0t05sd02x71168h34yh3hh0000gn/T/HelloCordova_2019-01-09_14-52-35.326.xcdistributionlogs'.
Exported HelloCordova to: /Users/shaz/Desktop/foo/platforms/ios/build/device
** EXPORT SUCCEEDED **

Running command: unzip -o -qq /Users/shaz/Desktop/foo/platforms/ios/build/device/HelloCordova.ipa
shell.js: internal error
Error: ENOTDIR: not a directory, rename '/Users/shaz/Desktop/foo/platforms/ios/build/device/Payload/HelloCordova.app' -> '/Users/shaz/Desktop/foo/platforms/ios/build/device/HelloCordova.app'
    at Object.fs.renameSync (fs.js:766:18)
    at /Users/shaz/Desktop/foo/platforms/ios/cordova/node_modules/shelljs/src/mv.js:77:8
    at Array.forEach (<anonymous>)
    at Object._mv (/Users/shaz/Desktop/foo/platforms/ios/cordova/node_modules/shelljs/src/mv.js:53:11)
    at Object.mv (/Users/shaz/Desktop/foo/platforms/ios/cordova/node_modules/shelljs/src/common.js:186:23)
    at /Users/shaz/Desktop/foo/platforms/ios/cordova/lib/run.js:91:31
    at _fulfilled (/Users/shaz/Desktop/foo/platforms/ios/cordova/node_modules/q/q.js:854:54)
    at self.promiseDispatch.done (/Users/shaz/Desktop/foo/platforms/ios/cordova/node_modules/q/q.js:883:30)
    at Promise.promise.promiseDispatch (/Users/shaz/Desktop/foo/platforms/ios/cordova/node_modules/q/q.js:816:13)
    at /Users/shaz/Desktop/foo/platforms/ios/cordova/node_modules/q/q.js:624:44

[shazron]

(UNRELATED) Ok, so it seems this line fails to delete a symlink:

cordova-ios/bin/templates/scripts/cordova/lib/run.js

Line 91 in 1d00e60

shell.rm('-rf', appFile);

so I replaced it with require('fs').unlinkSync(appFile) and now the app can deploy.

However, even though the app deploys, it does not launch the app like ios-deploy. Thus, this will be a loss of a feature.

[reck1610]

@shazron
I made a comment in the issue regarding this problem and a possible solution.
#429 (comment)

[shazron]

Even though it installs the app, it does not launch it -- so this is one loss of functionality. It was suggested ioslib could do this, but from what I can see it can only launch for simulator.

[erisu]

I will close out this ticket because:

• It is outdated with conflicts
• There has been no recent activity
• The alternative solution had loss of functionality to launch the app, that was installed/deployed.

I still want to thank you for the effort you put into this.