Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppIcon and LaunchImage Updates #512

Merged
merged 2 commits into from
Feb 5, 2019
Merged

AppIcon and LaunchImage Updates #512

merged 2 commits into from
Feb 5, 2019

Conversation

erisu
Copy link
Member

@erisu erisu commented Feb 5, 2019

Platforms affected

ios

What does this PR do?

Updates the AppIcon and LaunchImage image sets by adding the missing image images and making the naming conventions consistent.

What testing has been done on this change?

  • npm t
  • Build default hello world app

@erisu erisu changed the title Image updates AppIcon and LaunchImage Updates Feb 5, 2019
@codecov-io
Copy link

Codecov Report

Merging #512 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #512   +/-   ##
=======================================
  Coverage   74.75%   74.75%           
=======================================
  Files          11       11           
  Lines        1822     1822           
=======================================
  Hits         1362     1362           
  Misses        460      460
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/prepare.js 83.89% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5e2fba...bec130f. Read the comment docs.

Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants