(ios) Fix setting of target-device to handset in combination with plugins and resource files #546
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
IOs
Motivation and Context
when:
<preference name="target-device" value="handset" />
<resource-file src="GoogleService-Info.plist" />
then:
TARGETED_DEVICE_FAMILY
is reset to the default value of "1,2" while adding the resource file after handling the target device.Description
Instead of creating a new instance of the xcode project via
new xcode.project([...])
use the wrapped xcode project viaprojectFile.parse([...])
.This will reuse the cached xcode project, which is created when adding the plugins, and therefore maintain the changes when setting the target device.
The cached xcode project will then also be used when adding the resource file.
Testing
verify, that
TARGETED_DEVICE_FAMILY = 1;
is written to the project.pbxproj file.Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)I've updated the documentation if necessary