Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run prepare with the correct ConfigParser version #573

Merged
merged 2 commits into from
Mar 15, 2019

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Mar 15, 2019

Platforms affected

ios

Motivation and Context

See #535: The ConfigParser passed in by cordova-lib is constructed from the cordova-common version that cordova-lib is using, rather than the one that cordova-ios is using.

Description

Initialize the ConfigParser at the platform API level so that it uses the expected version.

Testing

All unit tests pass.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)

@dpogue dpogue requested a review from erisu March 15, 2019 05:45
@dpogue dpogue force-pushed the common-configparser branch from cc0dc61 to 3d08d87 Compare March 15, 2019 05:56
@dpogue dpogue force-pushed the common-configparser branch from 3d08d87 to d5c1bfa Compare March 15, 2019 06:03
@dpogue dpogue added this to the 5.0.1 milestone Mar 15, 2019
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Mar 15, 2019

Codecov Report

Merging #573 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
+ Coverage   74.57%   74.58%   +0.01%     
==========================================
  Files          11       11              
  Lines        1825     1826       +1     
==========================================
+ Hits         1361     1362       +1     
  Misses        464      464
Impacted Files Coverage Δ
bin/templates/scripts/cordova/Api.js 70.56% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4304be...eec1e82. Read the comment docs.

@dpogue dpogue force-pushed the common-configparser branch from d5c1bfa to 50080aa Compare March 15, 2019 06:23
@dpogue dpogue force-pushed the common-configparser branch from 50080aa to eec1e82 Compare March 15, 2019 18:07
@dpogue dpogue merged commit eede5c7 into apache:master Mar 15, 2019
@dpogue dpogue deleted the common-configparser branch March 15, 2019 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants