Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use whitespace as an indent indicator #614

Merged
merged 1 commit into from Nov 6, 2019
Merged

Don't use whitespace as an indent indicator #614

merged 1 commit into from Nov 6, 2019

Conversation

oliversalzburg
Copy link
Contributor

This is extremely confusing if your editor is not configured to clearly distinguish different sorts of whitespce

Platforms affected

iOS

Motivation and Context

This is just clean code style IMHO

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

This is extremely confusing if your editor is not configured to clearly distinguish different sorts of whitespce
@janpio
Copy link
Member

janpio commented May 9, 2019

Is it common or convention to use tabs in plist files vs spaces?

@oliversalzburg
Copy link
Contributor Author

@janpio What I understand from comments in the code and from observing XCode output files, it appears to be the default behavior of current XCode versions.

@raphinesse raphinesse merged commit 61a172c into apache:master Nov 6, 2019
raphinesse added a commit to raphinesse/cordova-ios that referenced this pull request Nov 6, 2019
@oliversalzburg oliversalzburg deleted the fix/plist-formatting branch November 11, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants