Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated component/duo package manager package definition #622

Merged
merged 1 commit into from
May 22, 2019

Conversation

janpio
Copy link
Member

@janpio janpio commented May 21, 2019

@brodycj brodycj added the bug label May 21, 2019
Copy link
Contributor

@brodycj brodycj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the following amendment added:

If we want to be strict about following semver conventions, I think this should be considered a breaking change for a new major release of cordova-ios.

This may be on the pedantic side, but I would rather we keep the strict compliance if possible.

@janpio
Copy link
Member Author

janpio commented May 22, 2019

Generally I would agree, but as this refers to 3.7.0-dev and hasn't been updated for 5 years (2014) I think it is safe to assume that this was broken for a long time and wasn't usable - and hasn't been used by anyone.

@codecov-io
Copy link

Codecov Report

Merging #622 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #622   +/-   ##
=======================================
  Coverage   74.24%   74.24%           
=======================================
  Files          11       11           
  Lines        1833     1833           
=======================================
  Hits         1361     1361           
  Misses        472      472

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dbd1f8...8a418a2. Read the comment docs.

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve and agree with Jan, this has been broken since right after it was added as it was never updated for getting newer versions, so I don't consider it a breaking change.

Also those 2 "package managers" are deprecated, so it wouldn't affect anybody.

@janpio janpio merged commit 0072977 into master May 22, 2019
@janpio janpio deleted the janpio-remove_component branch May 22, 2019 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants