-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(travis): add Xcode 10.2 & Xcode 11 #644
Conversation
no need to test on Xcode 10.1 any more? |
Codecov Report
@@ Coverage Diff @@
## master #644 +/- ##
=======================================
Coverage 74.24% 74.24%
=======================================
Files 11 11
Lines 1833 1833
=======================================
Hits 1361 1361
Misses 472 472 Continue to review full report at Codecov.
|
Now keeping Xcode 10.1 on Node.js 10 |
(this enables a clean merge from master)
We're testing with Xcode 11 only now, closing due to conflicts. |
My work is now wasted since people continued updating without even considering this proposal. I did request quite a few reviewers on GitHub, evidently ignored. And I recall raising some other PRs that never got reviewed. One thing is that it would have been nice to include Xcode 10.2 in Travis CI, as long as it can still keep working, like I proposed here. |
@brodybits If you still want this merged in, change the target branch to If there were to be any future minors releases for the |
Thanks @erisu, I think you are right since cordova-ios is rightfully dropping Xcode pre-11 in master (for upcoming major release). If we do apply this change to 5.x branch, I think we should try to ensure little things such as comments that I added are as consistent as possible with master. I really don't have so much extra time to pay attention to this right now. Some other thoughts for the record: I think I did overreact. My work was not really such a huge amount, and I do strongly favor the review process we follow to keep our repos as clean as possible. My apologies. Documentation needs to be updated as well, as I already reported in apache/cordova-docs#1056. |
No description provided.