Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmp@0.1 update in devDependencies #646

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Jul 14, 2019

Let’s see if Travis CI keeps working

@janpio
Copy link
Member

janpio commented Jul 14, 2019

(FYI: The Draft option for PRs is perfect for such things where you don't want others to look at a PR before it is ready as it clearly communicates that the PR is not ready yet.)

@codecov-io
Copy link

codecov-io commented Jul 14, 2019

Codecov Report

Merging #646 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #646   +/-   ##
=======================================
  Coverage   74.24%   74.24%           
=======================================
  Files          11       11           
  Lines        1833     1833           
=======================================
  Hits         1361     1361           
  Misses        472      472

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d618c4...6fdfd30. Read the comment docs.

@brodycj brodycj requested review from erisu and janpio July 14, 2019 18:50
@timbru31
Copy link
Member

Changelog: raszi/node-tmp@v0.0.33...v0.1.0 and README hint:

Version 0.1.0
Since version 0.1.0, all support for node versions < 0.10.0 has been dropped.

Most importantly, any support for earlier versions of node-tmp was also dropped.

If you still require node versions < 0.10.0, then you must limit your node-tmp dependency to versions below 0.1.0.

IMHO okay.

Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semver wise a breaking change, but only dropping Node.js <0.10.0 support.

@dpogue
Copy link
Member

dpogue commented Jul 15, 2019

cordova-ios already does not support node 0.10.0, so this shouldn't affect our versioning

@brodycj brodycj merged commit 0b22730 into apache:master Jul 15, 2019
@brodycj brodycj deleted the tmp-0.1-dev-update branch July 15, 2019 14:13
@brodycj
Copy link
Contributor Author

brodycj commented Jul 15, 2019

Thanks guys for the quick feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants