Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse common xcodebuild arguments in npm scripts #704

Merged
merged 1 commit into from
Oct 30, 2019

Conversation

raphinesse
Copy link
Contributor

Moves all common xcodebuild arguments used in npm scripts to a new script called xcodebuild.

@raphinesse raphinesse added this to the 5.0.2 milestone Oct 29, 2019
@codecov-io
Copy link

Codecov Report

Merging #704 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #704   +/-   ##
=======================================
  Coverage   74.08%   74.08%           
=======================================
  Files          11       11           
  Lines        1829     1829           
=======================================
  Hits         1355     1355           
  Misses        474      474

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33af7c4...f79cb5a. Read the comment docs.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me

@raphinesse raphinesse merged commit a0baeca into apache:master Oct 30, 2019
@raphinesse raphinesse deleted the dry-objc-tests branch October 30, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants