Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use arrow functions #747

Merged
merged 8 commits into from
Dec 24, 2019
Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented Dec 17, 2019

Motivation and Context

Modernize code

Description

  • Use lebab to apply --transform arrow and --transform arrow-return.
  • Reverted some of the applied arrow-return for readability.

Testing

  • npm t

@erisu erisu added this to the 6.0.0 milestone Dec 17, 2019
@erisu erisu requested a review from raphinesse December 17, 2019 23:56
Copy link
Contributor

@raphinesse raphinesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I flagged a few things that I would like to see changed.

bin/templates/scripts/cordova/lib/prepare.js Outdated Show resolved Hide resolved
bin/templates/scripts/cordova/lib/check_reqs.js Outdated Show resolved Hide resolved
bin/templates/scripts/cordova/lib/check_reqs.js Outdated Show resolved Hide resolved
bin/templates/scripts/cordova/lib/check_reqs.js Outdated Show resolved Hide resolved
bin/templates/scripts/cordova/lib/BridgingHeader.js Outdated Show resolved Hide resolved
tests/spec/unit/prepare.spec.js Outdated Show resolved Hide resolved
bin/templates/scripts/cordova/lib/clean.js Show resolved Hide resolved
bin/templates/scripts/cordova/lib/clean.js Outdated Show resolved Hide resolved
tests/spec/unit/lib/check_reqs.spec.js Outdated Show resolved Hide resolved
tests/spec/unit/lib/check_reqs.spec.js Outdated Show resolved Hide resolved
@erisu erisu marked this pull request as ready for review December 18, 2019 20:21
@erisu erisu force-pushed the v6-transform-arrow-func branch from 2a79ae5 to 08aa0f4 Compare December 18, 2019 21:30
@codecov-io
Copy link

codecov-io commented Dec 18, 2019

Codecov Report

Merging #747 into master will increase coverage by 0.02%.
The diff coverage is 63.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #747      +/-   ##
==========================================
+ Coverage   74.29%   74.32%   +0.02%     
==========================================
  Files          11       11              
  Lines        1852     1842      -10     
==========================================
- Hits         1376     1369       -7     
+ Misses        476      473       -3
Impacted Files Coverage Δ
...ates/scripts/cordova/lib/plugman/pluginHandlers.js 90.2% <100%> (ø) ⬆️
...in/templates/scripts/cordova/lib/BridgingHeader.js 95.45% <100%> (-0.07%) ⬇️
bin/templates/scripts/cordova/lib/run.js 21.42% <21.42%> (-0.7%) ⬇️
bin/templates/scripts/cordova/lib/build.js 50.76% <50%> (-0.26%) ⬇️
bin/templates/scripts/cordova/lib/projectFile.js 94.64% <50%> (+1.66%) ⬆️
bin/templates/scripts/cordova/Api.js 70.87% <50%> (+0.28%) ⬆️
bin/templates/scripts/cordova/lib/check_reqs.js 51.94% <70%> (ø) ⬆️
bin/templates/scripts/cordova/lib/prepare.js 83.91% <76.19%> (-0.07%) ⬇️
bin/templates/scripts/cordova/lib/Podfile.js 73.36% <85.71%> (ø) ⬆️
bin/templates/scripts/cordova/lib/versions.js 90.24% <88.23%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc9acac...6929dbe. Read the comment docs.

@erisu erisu requested a review from raphinesse December 18, 2019 23:49
Copy link
Contributor

@raphinesse raphinesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now 👍

@timbru31
Copy link
Member

timbru31 commented Dec 20, 2019

I've took the liberty to resolve the minor merge conflicts via the GitHub UI.

@erisu
Copy link
Member Author

erisu commented Dec 24, 2019

Thank you for fixing the merge conflicts @timbru31

@erisu erisu merged commit b764944 into apache:master Dec 24, 2019
@erisu erisu deleted the v6-transform-arrow-func branch December 24, 2019 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants