Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: do not alias this to self #748

Merged
merged 1 commit into from
Dec 24, 2019
Merged

refactor: do not alias this to self #748

merged 1 commit into from
Dec 24, 2019

Conversation

erisu
Copy link
Member

@erisu erisu commented Dec 17, 2019

Motivation and Context

Creating an alias is not required if using arrow functions.

Description

  • Searched and removed self = this and anything that used self.

Testing

  • npm t

@erisu erisu added this to the 6.0.0 milestone Dec 17, 2019
@erisu erisu requested a review from raphinesse December 17, 2019 23:58
@erisu erisu marked this pull request as ready for review December 24, 2019 01:49
@erisu erisu force-pushed the v6-transform-this-not-self branch from 3b54a73 to e6c4833 Compare December 24, 2019 02:52
@erisu erisu force-pushed the v6-transform-this-not-self branch from f10bb6a to 0a01163 Compare December 24, 2019 03:04
@erisu erisu merged commit 450dc03 into apache:master Dec 24, 2019
@erisu erisu deleted the v6-transform-this-not-self branch December 24, 2019 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphinesse raphinesse raphinesse approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@erisu @raphinesse