Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: transform split out variables #749

Merged
merged 1 commit into from
Dec 24, 2019

Conversation

erisu
Copy link
Member

@erisu erisu commented Dec 18, 2019

Motivation and Context

This maybe a personal opinion but, I feel that split out the variables can make it:

  • easier to search for the variable declaration.
  • quicker to distinguish the change/add/remove of a variable in a diff when on its own line.

Description

  • Use lebab to apply --transform multi-var .

Testing

  • npm t

@erisu erisu added this to the 6.0.0 milestone Dec 18, 2019
@erisu erisu requested a review from raphinesse December 18, 2019 00:03
Copy link
Contributor

@raphinesse raphinesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big fan of these changes stylistically, but they are correct.

So if we want them, they can be merged.

@erisu erisu force-pushed the v6-transform-split-var branch from 2cffc88 to 8115a93 Compare December 24, 2019 05:26
@erisu erisu marked this pull request as ready for review December 24, 2019 05:27
@codecov-io
Copy link

codecov-io commented Dec 24, 2019

Codecov Report

Merging #749 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #749   +/-   ##
=======================================
  Coverage   74.42%   74.42%           
=======================================
  Files          11       11           
  Lines        1830     1830           
=======================================
  Hits         1362     1362           
  Misses        468      468

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb313f4...8115a93. Read the comment docs.

@erisu erisu merged commit 2229e45 into apache:master Dec 24, 2019
@erisu erisu deleted the v6-transform-split-var branch December 24, 2019 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants