Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: transform object shorthand #750

Merged
merged 2 commits into from
Dec 24, 2019

Conversation

erisu
Copy link
Member

@erisu erisu commented Dec 18, 2019

Motivation and Context

Modernize code

Description

Use lebab to apply --transform obj-shorthand.

Testing

  • npm t

@erisu erisu added this to the 6.0.0 milestone Dec 18, 2019
@erisu erisu requested a review from raphinesse December 18, 2019 00:05
bin/templates/scripts/cordova/lib/prepare.js Outdated Show resolved Hide resolved
tests/spec/unit/prepare.spec.js Outdated Show resolved Hide resolved
@erisu erisu force-pushed the v6-transform-obj-shorthand branch from ea85f74 to d435ca5 Compare December 24, 2019 05:11
@erisu erisu force-pushed the v6-transform-obj-shorthand branch from d435ca5 to 717d847 Compare December 24, 2019 05:13
@erisu erisu marked this pull request as ready for review December 24, 2019 05:14
@codecov-io
Copy link

codecov-io commented Dec 24, 2019

Codecov Report

Merging #750 into master will not change coverage.
The diff coverage is 70%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #750   +/-   ##
=======================================
  Coverage   74.42%   74.42%           
=======================================
  Files          11       11           
  Lines        1830     1830           
=======================================
  Hits         1362     1362           
  Misses        468      468
Impacted Files Coverage Δ
bin/templates/scripts/cordova/Api.js 71.11% <ø> (ø) ⬆️
bin/templates/scripts/cordova/lib/projectFile.js 94.64% <ø> (ø) ⬆️
bin/templates/scripts/cordova/lib/check_reqs.js 51.94% <ø> (ø) ⬆️
bin/templates/scripts/cordova/lib/Podfile.js 73.58% <100%> (ø) ⬆️
bin/templates/scripts/cordova/lib/prepare.js 84.06% <100%> (ø) ⬆️
...ates/scripts/cordova/lib/plugman/pluginHandlers.js 90.2% <100%> (ø) ⬆️
...in/templates/scripts/cordova/lib/BridgingHeader.js 95.45% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 450dc03...717d847. Read the comment docs.

@erisu erisu merged commit cb313f4 into apache:master Dec 24, 2019
@erisu erisu deleted the v6-transform-obj-shorthand branch December 24, 2019 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants