refactor: drop uiwebview & add wkwebview

[erisu]

Motivation, Context, Description

• Removes UIWebView
• Integrates cordova-plugin-wkwebview-engine
• Renames WKWebView engine plugin classes to not conflict with Ionic.
  • Prefixed w/ CDVWebView:
  • Notice: Plugins should not use the follow prefix CDV. It is typically used for Cordova's internal class naming convention. If a plugin happens to uses the same class name, it will create conflicts. As well, if any changes were made on Cordova's end and happens to break the plugin, the plugin would need to make the corrections because the plugin decided to use and conflict with Cordova's internal naming convention.
• Removes WK_WEB_VIEW_ONLY preference options.
• fixes: Remove all UIWebView code? #661
• closes: Fix #661: Removed all UIWebView code. #663

Testing

• npm t
• cordova platform add
• cordova requirements ios
• cordova prepare ios
• cordova build ios --release --device
  • Uploaded Manually Built IPA
  • Launch Manual Uploaded IPA
• cordova run ios --release --emulator
• IAB test
  • cordova plugin add cordova-plugin-inappbrowser@3.2.0
  • cordova build ios --release --device
    • Uploaded Manually Built IPA
    • Launch Manual Uploaded IPA

Checklist

• I've run the tests to see all new and existing tests pass

[codecov-io]

Codecov Report

Merging #773 into master will decrease coverage by 0.15%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #773      +/-   ##
==========================================
- Coverage   74.42%   74.26%   -0.16%     
==========================================
  Files          11       11              
  Lines        1830     1815      -15     
==========================================
- Hits         1362     1348      -14     
+ Misses        468      467       -1

Impacted Files	Coverage Δ
bin/templates/scripts/cordova/lib/prepare.js	83.74% <100%> (-0.32%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 266d339...8ace315. Read the comment docs.

[dpogue]

My understanding is that the following code from CDVAppDelegate has no effect with WKWebView and can also be removed: https://github.com/apache/cordova-ios/blob/master/CordovaLib/Classes/Public/CDVAppDelegate.m#L28-L38

[dpogue]

Does this get used anywhere by WKWebView or should it be removed entirely?

[erisu]

CDVWebViewNavigationType is used here.

https://github.com/erisu/cordova-ios/blob/refactor/swap-webviews/CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m#L105-L132

https://github.com/erisu/cordova-ios/blob/refactor/swap-webviews/CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m#L134-L137

[knight9999]

I confirmed that test app works properly in my Mac environment.
Supposing other plugins those using WK_WEB_VIEW_ONLY flag will be updated soon according to this PR,
#773 (review)
I think there is no problem.

[NiklasMerz]

I think it's a good idea to set WK_WEB_VIEW_ONLY for now. We can remove that later (once InAppBrowser is ready).

I tested this PR in an app which is using WKWebView and IAB and it works fine.

[jpike88]

@erisu now that this has been merged when can we look forward to next release?

[brodycj]

If you need this update now, I think your best bet at this point would be to install from GitHub, for example:

• cordova platform add github:apache/cordova-ios
• cordova platform add github:apache/cordova-ios#bce99f94

There should also be a nightly tag on npm. In general, we do not actively support unstable versions from master or from nightly.

My understanding is that there are some breaking changes still in progress before we are ready to publish the new release.

In case you have any questions about the upcoming release I would highly recommend you followup with us on Slack or on the mailing list, follow links in the footer of cordova.io or cordova.apache.org.