Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (CDVWebViewEngine): JavaScript to Native Call Not Working #787

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented Feb 13, 2020

Motivation and Context

Fix error when calling WebViewEngine JavaScript Code.

Description

When calling the WebViewEngine JavaScript

window.WkWebView.allowsBackForwardNavigationGestures(true);

The code does not process and an error displays in the Native logs,

2020-02-13 18:51:12.416046+0900 MyAppName[48951:8545412] ERROR: Plugin 'CDVWebViewEngine' not found, or is not a CDVPlugin. Check your plugin mapping in config.xml.
2020-02-13 18:51:12.416177+0900 MyAppName[48951:8545412] FAILED pluginJSON = ["INVALID","CDVWebViewEngine","allowsBackForwardNavigationGestures",[true]]

This PR adds the missing declaration which makes the JavaScript work again.

Testing

  • npm t
  • cordova platform add
  • cordova build ios
  • Run Simulator
  • Test JavaScript method and verify execution

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added the bug label Feb 13, 2020
@erisu erisu added this to the 6.0.0 milestone Feb 13, 2020
@erisu erisu changed the title fix (CDVWebViewEngine): JavaScript Not Working fix (CDVWebViewEngine): JavaScript to Native Call Not Working Feb 13, 2020
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@erisu erisu merged commit 3c418eb into apache:master Feb 13, 2020
@erisu erisu deleted the fix/wkwebview-js branch February 13, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants