Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated method viewDidUnload #788

Merged
merged 1 commit into from
Feb 14, 2020
Merged

chore: remove deprecated method viewDidUnload #788

merged 1 commit into from
Feb 14, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented Feb 14, 2020

Motivation and Context

Remove deprecated code.
https://developer.apple.com/documentation/uikit/uiviewcontroller/1621383-viewdidunload

Description

Deleted viewDidUnload usage.

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 6.0.0 milestone Feb 14, 2020
@erisu erisu requested a review from jcesarmobile February 14, 2020 05:34
NiklasMerz
NiklasMerz approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method is not called according to documentation. One warning less is always good 👍

jcesarmobile
jcesarmobile approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisu erisu merged commit 72b9651 into apache:master Feb 14, 2020
@erisu erisu deleted the chore/remove-viewDidUnload branch February 14, 2020 13:40
NiklasMerz pushed a commit to GEDYSIntraWare/cordova-ios that referenced this pull request Feb 24, 2020
@erisu @NiklasMerz
chore: remove deprecated method viewDidUnload (apache#788)
1c8884b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiklasMerz NiklasMerz NiklasMerz approved these changes

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@erisu @jcesarmobile @NiklasMerz