Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING TEST] try removing internal -Info.plist filter - DO NOT MERGE #792

Closed

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Feb 18, 2020

From review of changes proposed in PR #765, I discovered that the following change would not cause a test failure:

diff --git a/bin/templates/scripts/cordova/lib/projectFile.js b/bin/templates/scripts/cordova/lib/projectFile.js
index 35a5a917..6ab43422 100644
--- a/bin/templates/scripts/cordova/lib/projectFile.js
+++ b/bin/templates/scripts/cordova/lib/projectFile.js
@@ -41,7 +41,7 @@ function parseProjectFile (locations) {
     xcodeproj.parseSync();
 
     const xcBuildConfiguration = xcodeproj.pbxXCBuildConfigurationSection();
-    const plist_file_entry = _.find(xcBuildConfiguration, entry => entry.buildSettings && entry.buildSettings.INFOPLIST_FILE);
+    const plist_file_entry = _.find(xcBuildConfiguration, entry => entry.buildSettings);
     const plist_file = path.join(project_dir, plist_file_entry.buildSettings.INFOPLIST_FILE.replace(/^"(.*)"$/g, '$1').replace(/\\&/g, '&'));
     const config_file = path.join(path.dirname(plist_file), 'config.xml');
 

Considering that this internal filter needs to be adapted to resolve issue #764, I would conclude that this indicates a missing test case.

I think we need to add a test case for this we can proceed with further consideration of PR #765.

@timbru31
Copy link
Member

Brody, what's the status on this? This sounds like it should be an issue with missing tests instead of stale, do-not-merge draft PR?

@brodycj
Copy link
Contributor Author

brodycj commented Apr 16, 2020

I just raised #826 to track this missing test case. Unfortunately I have no time to investigate further right now.

@brodycj brodycj closed this Apr 16, 2020
@brodycj brodycj deleted the try-removing-internal-info-plist-filter branch April 16, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants