Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: change comment values for MediaTypesRequiringUserActionForPlayback #800

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

jcesarmobile
Copy link
Member

Comment says default value is "NO", but that was for the old entry, the new entry doesn't allow "NO".

I've put "none" since that's the default in defaults.xml

@jcesarmobile jcesarmobile requested a review from erisu February 27, 2020 09:47
@codecov-io
Copy link

codecov-io commented Feb 27, 2020

Codecov Report

Merging #800 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #800   +/-   ##
======================================
  Coverage    74.2%   74.2%           
======================================
  Files          13      13           
  Lines        1849    1849           
======================================
  Hits         1372    1372           
  Misses        477     477

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f09b879...b650ac0. Read the comment docs.

@jcesarmobile jcesarmobile merged commit 6777dfd into master Feb 27, 2020
@jcesarmobile jcesarmobile deleted the jcesarmobile-patch-1 branch February 27, 2020 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants