Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED #803

Merged
merged 1 commit into from
Feb 29, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented Feb 29, 2020

Motivation and Context

Apply Xcode Recommendation to enable the static analyzer to check for missing localizability.

Description

Added CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED flag.

This flag will only warn when a non-localized string is passed to a user-interface method. It will help people understand why something might not display in the correct localization.

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 6.0.0 milestone Feb 29, 2020
@erisu erisu requested a review from dpogue February 29, 2020 05:40
@codecov-io
Copy link

codecov-io commented Feb 29, 2020

Codecov Report

Merging #803 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #803   +/-   ##
======================================
  Coverage    74.2%   74.2%           
======================================
  Files          13      13           
  Lines        1849    1849           
======================================
  Hits         1372    1372           
  Misses        477     477

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6777dfd...32c575a. Read the comment docs.

@erisu erisu merged commit 2922437 into apache:master Feb 29, 2020
@erisu erisu deleted the refactor/enable-localize-analyzer branch February 29, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants