Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(iOS) Fix two compile-time type warnings and simplify code by using auto boxing of NSNumber. #825

Merged
merged 1 commit into from
Apr 18, 2020

Conversation

PlanetaryCode
Copy link
Contributor

@PlanetaryCode PlanetaryCode commented Apr 15, 2020

Platforms affected

iOS

Motivation and Context

I hate disregarded warnings at compile time.

Description

Existing code was converting to NSNumber with wrong init method for the type.
Rather than change the method called I switched to auto boxing the values which automatically does the right thing in less code.

Testing

Ran npm test

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@PlanetaryCode PlanetaryCode changed the title Fix two compile-time type warnings and simplify code by using auto boxing of NSNumber. (iOS) Fix two compile-time type warnings and simplify code by using auto boxing of NSNumber. Apr 15, 2020
@codecov-io
Copy link

codecov-io commented Apr 15, 2020

Codecov Report

Merging #825 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #825   +/-   ##
=======================================
  Coverage   74.20%   74.20%           
=======================================
  Files          13       13           
  Lines        1849     1849           
=======================================
  Hits         1372     1372           
  Misses        477      477           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fca1f3b...226b4ff. Read the comment docs.

Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dpogue dpogue merged commit 755484b into apache:master Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants