Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking(pod): remove unused API & bump minimum version requirements to 1.8.0 #849

Merged
merged 2 commits into from
May 19, 2020
Merged

breaking(pod): remove unused API & bump minimum version requirements to 1.8.0 #849

merged 2 commits into from
May 19, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented May 16, 2020

Motivation, Context, & Description

Improve cocoapods support by increasing the minimum required version and removing unused logic.

  • Increase minimum supported version starting at 1.8.0
    • Since 1.8.0, CDN is enabled by default and is highly recommended as it no longer requires to checkout and sync the cocoapods repo. This greatly improves the speed.

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 6.0.0 milestone May 16, 2020
jcesarmobile
jcesarmobile approved these changes May 16, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@erisu erisu merged commit 1f753f6 into apache:master May 19, 2020
@erisu erisu deleted the breaking/cocoapods-upgrade branch May 19, 2020 00:54
@AdamLak
Copy link
Contributor

AdamLak commented Nov 5, 2020

Too much refactor:
#1018

antgel pushed a commit to graduway/cordova-ios that referenced this pull request Jun 3, 2021
@erisu
breaking(pod): remove unused API & bump minimum version requirements …
e7268ac 
…to 1.8.0 (apache#849)

* breaking: remove unused API check_cocoapods_repo_size
* breaking(pod): bump minimum version requirements to 1.8.0
antgel pushed a commit to graduway/cordova-ios that referenced this pull request Jun 3, 2021
@erisu
breaking(pod): remove unused API & bump minimum version requirements …
8896a99 
…to 1.8.0 (apache#849)

* breaking: remove unused API check_cocoapods_repo_size
* breaking(pod): bump minimum version requirements to 1.8.0
antgel pushed a commit to graduway/cordova-ios that referenced this pull request Jul 19, 2021
@erisu
breaking(pod): remove unused API & bump minimum version requirements …
ecc06a5 
…to 1.8.0 (apache#849)

* breaking: remove unused API check_cocoapods_repo_size
* breaking(pod): bump minimum version requirements to 1.8.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

@timbru31 timbru31 timbru31 approved these changes

@dpogue dpogue Awaiting requested review from dpogue

@NiklasMerz NiklasMerz Awaiting requested review from NiklasMerz

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@erisu @AdamLak @timbru31 @jcesarmobile