Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (npm): add ignore list #863

Merged
merged 1 commit into from
May 22, 2020
Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented May 21, 2020

Motivation, Context & Description

  • Add .npmignore file
  • Remove files that are not needed to be packaged with the release build.
  • Decrease package size

Before Ignore

=== Tarball Details ===
package size:  1.9 MB
unpacked size: 3.5 MB
total files:   390

After Ignore

=== Tarball Details ===
package size:  420.0 kB
unpacked size: 1.2 MB
total files:   185

Testing

  • cordova platform add
  • cordova build
  • cordova run

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 6.0.0 milestone May 21, 2020
@erisu erisu requested review from dpogue and timbru31 May 21, 2020 15:42
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2020

Codecov Report

Merging #863 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #863   +/-   ##
=======================================
  Coverage   74.85%   74.85%           
=======================================
  Files          13       13           
  Lines        1742     1742           
=======================================
  Hits         1304     1304           
  Misses        438      438           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1714953...2d59b55. Read the comment docs.

@erisu erisu merged commit 76bc709 into apache:master May 22, 2020
@erisu erisu deleted the chore/npm-pack-cleanup branch May 22, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants